Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path in deployed CTFE public key file for ephemeral TUF creation should include "ctfe" to correctly hint as to its use in TUF creation #670

Open
LewisThomas opened this issue Nov 29, 2023 · 3 comments

Comments

@LewisThomas
Copy link

https://github.com/sigstore/helm-charts/blob/b3876089c778987b29a89cee6ec14c6fd3679336/charts/scaffold/values.yaml#L82C16-L82C16

needs to be called CTFE instead of ctlog.

As per here:

https://github.com/sigstore/scaffolding/blob/2be6921bb64c02ec00e65c69b3dc41191df5f5cd/pkg/repo/repo.go#L137C11-L137C11

Slack Thread + GitHub issue likely related:
sigstore/cosign#3386
https://sigstore.slack.com/archives/C01PZKDL4DP/p1700838479395349?thread_ts=1694462110.654769&cid=C01PZKDL4DP

@federico-falconieri-form3

@LewisThomas I also reported this here sigstore/scaffolding#873

@haydentherapper
Copy link
Contributor

#673 should fix this using the fallback names. Can you confirm this?

@federico-falconieri-form3
Copy link

federico-falconieri-form3 commented Dec 6, 2023

#673 should fix this using the fallback names. Can you confirm this?

@haydentherapper I can confirm #673 fixes this.

However #673 did not update the default values of the scaffold chart, so the bug is still present when one does not override them. I've proposed a fix in #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants