Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache option for Windows #497

Closed
Fydon opened this issue Apr 23, 2024 · 1 comment · Fixed by #579
Closed

Cache option for Windows #497

Fydon opened this issue Apr 23, 2024 · 1 comment · Fixed by #579
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Fydon
Copy link

Fydon commented Apr 23, 2024

Description

Using git config --global gitsign.connectorID https://github.com/login/oauth with gitsign and then perform multiple commits can result in reaching the secondary rate limit on calling the GitHub repository. Current cache option doesn't work on Windows as mention in #194.

image

Version

gitsign version v0.10.1
parsed config:
{
  "Fulcio": "https://fulcio.sigstore.dev",
  "FulcioRoot": "",
  "Rekor": "https://rekor.sigstore.dev",
  "RekorMode": "online",
  "ClientID": "sigstore",
  "RedirectURL": "",
  "Issuer": "https://oauth2.sigstore.dev/auth",
  "ConnectorID": "https://github.com/login/oauth",
  "TokenProvider": "",
  "TimestampURL": "",
  "TimestampCert": "",
  "LogPath": "",
  "CommitterName": "Foo",
  "CommitterEmail": "Bar",
  "MatchCommitter": false,
  "Autoclose": true,
  "AutocloseTimeout": 6
}
@Fydon Fydon added the bug Something isn't working label Apr 23, 2024
@wlynch
Copy link
Member

wlynch commented Apr 23, 2024

I'm open to this, but I do not have any sort of Windows socket experience (or much experience building Windows apps in general). 😓

The first step would be to hide unix-specific syscalls behind a build flag:

$ GOOS=windows go build ./cmd/gitsign-credential-cache
# github.com/sigstore/gitsign/cmd/gitsign-credential-cache
./main.go:43:10: undefined: syscall.Umask

@wlynch wlynch added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants