Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding information on sigstore-go #345

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

hayleycd
Copy link
Contributor

@hayleycd hayleycd commented Nov 6, 2024

Summary

Partially addresses #324 by adding information on sigstore-go

Release Note

None

Signed-off-by: hayleycd <[email protected]>
Signed-off-by: hayleycd <[email protected]>
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 314119b
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/672d770f40ecf10009804a79
😎 Deploy Preview https://deploy-preview-345--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hayleycd
Copy link
Contributor Author

hayleycd commented Nov 6, 2024

@codysoyland @steiza tagging you here in case you want to review. Otherwise, @haydentherapper or @cmurphy can you take a look?

Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion to clarify the difference between sigstore-go and cosign, otherwise looks good to me!

content/en/language_clients/go/overview.md Outdated Show resolved Hide resolved
@hayleycd
Copy link
Contributor Author

hayleycd commented Nov 8, 2024

Thank you for the review @steiza. I made the suggested change (and had to fix the DCO) but we should be good now.

@haydentherapper haydentherapper merged commit cb7a54b into sigstore:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants