Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding info for JS client. #343

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Conversation

hayleycd
Copy link
Contributor

@hayleycd hayleycd commented Nov 3, 2024

Summary

Partially addresses #324

Release Note

None

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 8b1ea18
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/672e5d38ac830c000840a236
😎 Deploy Preview https://deploy-preview-343--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hayleycd
Copy link
Contributor Author

hayleycd commented Nov 4, 2024

@bdehamer @haydentherapper suggested that I tag you in for review. I'm happy to make changes. Please let me know what you think.

Copy link

@bdehamer bdehamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for the code samples.

content/en/language_clients/javascript/overview.md Outdated Show resolved Hide resolved
content/en/language_clients/javascript/overview.md Outdated Show resolved Hide resolved
content/en/language_clients/javascript/overview.md Outdated Show resolved Hide resolved
Signed-off-by: hayleycd <[email protected]>
@hayleycd
Copy link
Contributor Author

hayleycd commented Nov 6, 2024

Thanks for the review @bdehamer. Let me know if you require any more changes!

haydentherapper
haydentherapper previously approved these changes Nov 8, 2024
@haydentherapper
Copy link
Contributor

@hayleycd Can you rebase for the conflict?

@hayleycd
Copy link
Contributor Author

hayleycd commented Nov 8, 2024

@haydentherapper Conflicts have been resolved but the review is now stale. Can you approve again?

@haydentherapper haydentherapper merged commit 8406c1d into sigstore:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants