Should pyformance_usecase.py include a call to report_now()?

[vinaytota-optimizely]

I created a script modeled on the example pyformance_usecase.py script, however I found that my metrics don't seem to be flushed unless I call report_now(), previously I only called stop().

Is this some kind of user error (I can provide my whole script), or is it a mistake in the example script?

[mpetazzoni]

Calling stop() should flush all pending metrics. Are you sure you are starting the SignalFxReporter? Share your script, if you can, it would definitely help me spot anything that might be missing.

[vinaytota-optimizely]

Here's my script (edited somewhat for brevity)
https://gist.github.com/vinaytota-optimizely/af8b78b0ebdf0555d2c211e180be65fc
I'm calling start on pyformance but not signalfx.SignalFx. I'm calling stop on both, but maybe in the wrong order?

[mpetazzoni]

Looks fine. Can you check that SignalFxReporter.report_now() is correctly called periodically by Pyformance?

Also, depending on how quickly your run_test() method runs, it seems possible that metric updates since the last report are lost since we don't call report_now() one last time on stop. I can make the SignalFxReporter do that automatically, but no other Pyformance reporter seems to care about it?