Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Protobuf version #138

Open
davipaula opened this issue Jun 12, 2023 · 2 comments
Open

Upgrade Protobuf version #138

davipaula opened this issue Jun 12, 2023 · 2 comments

Comments

@davipaula
Copy link

Hi team,

is it possible to upgrade the Protobuf version to 4.2X? The reason I ask is because one of my projects uses Protobuf, and the newest versions provide performance improvements when working with large payloads (which is exactly my usecase).

Currently, the requirement in SignalFX is set to >=3.0.0,<4.21.0 due to issues with 4.21.0 (see #132). The Protobuf version 4.21.0 has been yanked due to different problems with this release. The new versions are supposed to fix these problems.

I understand that 4.2X introduce some breaking changes, so the upgrade needs to be thoroughly tested.

I am happy to open a PR if it helps.

Thanks in advance!

@damanfb
Copy link

damanfb commented Feb 12, 2024

Was there any movement or plans on this?

I have an app that is also using splunk-opentelemetry for auto instrumentation and upgrading that to address a vulnerability requires protobuf>=4.23,<5.0 but signalfx still requires >=3.0.0,<4.21.0

@davipaula
Copy link
Author

@damanfb this repo seems to be inactive, so I don't believe the maintainers will address this issue.

A possible solution is to fix your SignalFX version to 1.1.14, because it only requires Protobuf >= 3.0.0 (see the requirements.txt). The only difference between 1.1.14 and 1.1.16 is the Protobuf version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants