Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @context, alsoKnownAs, controller to DIDDoc #73

Closed
tdiesler opened this issue Feb 24, 2023 · 3 comments · Fixed by #77
Closed

Add @context, alsoKnownAs, controller to DIDDoc #73

tdiesler opened this issue Feb 24, 2023 · 3 comments · Fixed by #77

Comments

@tdiesler
Copy link
Contributor

@victormartinez-work
Copy link

@dkulic @yvgny Can we check if Thomas recommendations are included in other didcomm libraries, specially didcomm python? Let's duplicate the issue in the other libraries if needed

@tdiesler
Copy link
Contributor Author

tdiesler commented Mar 3, 2023 •
edited
Loading

@context is critical because it seems to be an required attribute and WaltId (correctly) rejects docs that don't have a @context

The JSON-LD Context is either a string or a list containing any combination of strings and/or ordered maps.

tdiesler added a commit to tdiesler/didcomm-jvm that referenced this issue Mar 3, 2023
@tdiesler
[sicpa-dlab#73] Add @context, alsoKnownAs, controller to DIDDoc
f5a72ff
@tdiesler
Copy link
Contributor Author

tdiesler commented Mar 3, 2023

PR: #77

tdiesler added a commit to tdiesler/didcomm-jvm that referenced this issue Mar 4, 2023
@tdiesler
[sicpa-dlab#73] Add @context, alsoKnownAs, controller to DIDDoc
4f2d769
@dkulic dkulic linked a pull request Mar 7, 2023 that will close this issue
[#76] didcomm-jvm cannot decode did:peer resolved document #77
Merged
@dkulic dkulic closed this as completed in #77 Mar 8, 2023
dkulic pushed a commit that referenced this issue Mar 8, 2023
@tdiesler
[#76] didcomm-jvm cannot decode did:peer resolved document (#77)
34c713e 
* [#70] Review and fix serialized Did Document representation

* [#72] Add missing properties to DID Document e.g. assertionMethod

* [#76] didcomm-jvm cannot decode did:peer resolved document

* [#73] Add @context, alsoKnownAs, controller to DIDDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#76] didcomm-jvm cannot decode did:peer resolved document tdiesler/didcomm-jvm
2 participants
@tdiesler @victormartinez-work