Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

didcomm-jvm library doesn't have latest ACK header implementation #62

Open
ArtemPivovarov opened this issue Nov 2, 2022 · 0 comments
Open

Comments

@ArtemPivovarov
Copy link

ArtemPivovarov commented Nov 2, 2022

What

Current didcomm-jvm implementation treats please_ack header as a boolean and ack header as a string.
According to the current specs both headers should be treated as array of strings (IDs).

Why

Because of that, original ack and please_ack headers cannot be used in current dependent applications with respect to current specification

Success Criteria

ack and please_ack headers treated as array of strings.

Additional info

Implementation can be found in Message class

data class Message(
    ...
    val pleaseAck: Boolean?,
    val ack: String?,
    ...
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant