Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pp.inference API #2

Open
4 tasks
shwang opened this issue Jul 23, 2019 · 0 comments
Open
4 tasks

Simplify pp.inference API #2

shwang opened this issue Jul 23, 2019 · 0 comments

Comments

@shwang
Copy link
Owner

shwang commented Jul 23, 2019

The pp.inference API is a mess. All but two of the dozen or so functions available were used for experimentation/troubleshooting and are irrelevant for the paper, so it might be a good idea to scrap stuff for clarity.

For example, there's "gradient-descent to get MLE beta" code and an entire "hardmax/" folder, which is superfluous now that the "softmax" maxent inference has been removed from the repo.

API rework route:

  • Maybe: pp.inference.hardmax => pp.inference
  • Get rid of all the inference tools except those we actually use in Andrea's crazy fly repo.
  • Submit PRs to all the repos that depend on this to install from pypi instead so they can use the legacy interface (pip install pedestrian-prediction == 0.1)
  • Maybe write a note on the README.md for people who are referencing crazy fly
@shwang shwang changed the title pp.inference is a mess Simplify pp.inference API Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant