Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support marian #12

Open
shuoyangd opened this issue Jan 13, 2019 · 2 comments
Open

support marian #12

shuoyangd opened this issue Jan 13, 2019 · 2 comments
Assignees

Comments

@shuoyangd
Copy link
Owner

shouldn't be hard :)

@mjpost
Copy link
Collaborator

mjpost commented Jan 17, 2019

This is a good idea.

One thing we also might consider is allowing all the decoder tape files to be loaded at the same time. This would require renaming tasks like "decode" to "sockeye_decode" and creating a variable for downstream constraints. The nice thing, though, is that you could branch on which decoder to use, and therefore easily build contrastive baselines.

Might not be worth the trouble, though...

@shuoyangd
Copy link
Owner Author

IMO that's a bit too much a corner-case scenario -- even if such scenario exists, one may as well clone 3 different copies of the pipeline and run 3 experiments with different decoders imported.

There's that decoder option mapping issue as well -- different decoders will have same options for some of the stuff, and different ones for others. Normalizing these options sounds like a daunting task to me.

@shuoyangd shuoyangd self-assigned this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants