About design-system components.

[alantoa]

design-system components add some extra props.

The current components are all using children props, would result in having to use double <blockquote>.

Maybe we can add a props to use single tag.

Just like,

Before:

  <Text>Text</Text>

  <Button>Title</Button>

After :

  <Text tx="Text" />

  <Button title="Title" />

I think it can make the code cleaner, what do you think?

[axeldelafosse]

I think it can make the code cleaner, what do you think?

I personally don't think that it looks cleaner. It feels more natural to use children (like you would with bare HTML)

[alantoa]

Alright, I think JSX should be more flexible than HTML and do it with less code, JSX could support both methods~ 😄

[alantoa]

[enesozturk]

They are both the same for me as readiblity. I think this should depend on other features of the Text component (or Button). Maybe we should consider these also for future.

Here is an example: When we want to enable the multi-lang feature, we will probably go in two ways;

• Call the translate module in Text comp and pass translateId (or something like that) prop to it. In this way, we don't need to import i18 in every component we use Text. Big plus.

<Text translateId="components.info.description" />

• Passing translated string as children to Text. In this usage, we need to import i18n in all the components we use Text.

<Text>
  {I18n.t("components.info.description")}
</Text>

If we don't handle these or some other features, they are almost the same for me.

[alantoa]

Yeah, I agree!