Performance improvement for large texts with many HTML spans #994
+3,718
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 6483564 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr;
This PR implements a huge performance improvement for large files with many html spans (e.g. links).
Full version
We recently had a case of a large markdown file (~2MB) including a table with ~4000 links. This took about 15-20s to process.
This PR fixes that by massively reducing the amount of string copies.
I added a performance test case that shows a speed improvement of about 2000%.
If this gets accepted, it'd be nice to also backport it to 2.x.x (which is easily done by rebasing this branch on 2.1.0 - no conflicts involved).