Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update check test #2614

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix: update check test #2614

merged 2 commits into from
Sep 26, 2023

Conversation

mitelg
Copy link
Contributor

@mitelg mitelg commented Sep 25, 2023

1. Why is this change necessary?

  • fixing the failing test
  • removing the "draft" option, as a draft release is only visible for users with push rights to the repository. So in fact not usable for normal merchants.

@mitelg mitelg changed the title Fix/update check test Fix: update check test Sep 25, 2023
@github-actions
Copy link

Warnings
⚠️ The Pull Request doesn't contain any changes to the Upgrade file

@mitelg mitelg enabled auto-merge (rebase) September 25, 2023 14:56
@mitelg mitelg self-assigned this Sep 25, 2023
@mitelg mitelg merged commit 51e5191 into 5.7 Sep 26, 2023
26 checks passed
@mitelg mitelg deleted the fix/update-check-test branch September 26, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisGarding DennisGarding DennisGarding approved these changes

@ennasus4sun ennasus4sun ennasus4sun approved these changes

@aragon999 aragon999 Awaiting requested review from aragon999

@mkreusch mkreusch Awaiting requested review from mkreusch

@rathmerdominik rathmerdominik Awaiting requested review from rathmerdominik

@PascalThesing PascalThesing Awaiting requested review from PascalThesing

Assignees

@mitelg mitelg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitelg @DennisGarding @ennasus4sun