-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't generate a 404 from Shopware for missing images #1461
Comments
[public] Shopware automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-38057. This link is only intended for Shopware employees and for internal use only. [created from NEXT-38057, comment 490378] |
In the Caddy config, we have
I think we could adopt this to Nginx (idk what you are using) |
we have customers with apache or nginx, do you want me to write a PR? |
would be nice if you could adjust the documentation, I think you know more what you do there :) |
NGINX: #1480 |
Apache: #4730 |
PHP Version
/
Shopware Version
6.6
Affected area / extension
Platform(Default)
Expected behaviour
On a missing media file in media or themes folder, shopware should not be instancieted at all
Actual behaviour
At the moment, for every request resulting in a 404 from the web server, the Shopware index.php is called by .htaccess or nginx configuration.
This can create a negative performance impact, when clients try to access non-existing files like missing images or ico files.
For performance reasons, I suggest adding an option, to remove the media fallback completely ( in the installer for example )
How to reproduce
call a non existent media file ( you'll see a 404 Shopware page )
The text was updated successfully, but these errors were encountered: