Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visits counts not being deleted when deleting short URL or orphan visits #2268

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 15, 2024

Closes #2264

When deleting short URL visits or orphan visits, also delete the corresponding short url visits counts and orphan visits counts.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.66%. Comparing base (a6e0916) to head (178a99b).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...dule/Core/src/EventDispatcher/Event/UrlVisited.php 33.33% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2268      +/-   ##
=============================================
- Coverage      93.70%   93.66%   -0.05%     
+ Complexity      1655     1654       -1     
=============================================
  Files            272      272              
  Lines           5781     5774       -7     
=============================================
- Hits            5417     5408       -9     
- Misses           364      366       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 9b7b914 into shlinkio:develop Nov 15, 2024
31 checks passed
@acelaya acelaya deleted the feature/delete-visits-fix branch November 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant