Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v0.12.0 installation post #106

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Nov 5, 2023

Changes

Provide installation steps for v0.12.0

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2023
@qu1queee qu1queee force-pushed the qu1queee/release_0.12.0 branch 2 times, most recently from 6cfeab7 to 01acb0a Compare November 7, 2023 15:11
@qu1queee qu1queee changed the title Add v0.12.0 post Add v0.12.0 installation post Nov 8, 2023
Provide installation steps
@qu1queee qu1queee added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 8, 2023
@qu1queee qu1queee marked this pull request as ready for review November 8, 2023 12:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2023
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @qu1queee! I've offered a few suggestions. HTH.

content/en/blog/posts/2022-09-09-build-release-v0.12.0.md Outdated Show resolved Hide resolved
content/en/blog/posts/2022-09-09-build-release-v0.12.0.md Outdated Show resolved Hide resolved
content/en/blog/posts/2022-09-09-build-release-v0.12.0.md Outdated Show resolved Hide resolved
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
@qu1queee qu1queee requested a review from rolfedh November 8, 2023 17:35
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks good to me! Does it make sense to take our releases out of the "draft" state?

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 1004066 into main Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants