Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the prerequisites in the getting started section #101

Conversation

ayushsatyam146
Copy link
Contributor

@ayushsatyam146 ayushsatyam146 commented Aug 16, 2023

Changes

Solves #93 Updated the prerequisites in the getting started section. Changed the installation URLs to use v0.11.0 and added tekton as a prerequisite.

Submitter Checklist

  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2023
@gabemontero gabemontero removed their request for review August 16, 2023 12:29
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Ayush! I've contributed some style suggestions including some short explanations. Please let me know if you have questions or if there's any more I can do to help.

content/en/docs/getting-started/installation.md Outdated Show resolved Hide resolved
content/en/docs/getting-started/installation.md Outdated Show resolved Hide resolved
content/en/docs/getting-started/installation.md Outdated Show resolved Hide resolved
content/en/docs/getting-started/installation.md Outdated Show resolved Hide resolved
content/en/docs/getting-started/installation.md Outdated Show resolved Hide resolved
@coreydaley
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@qu1queee qu1queee self-requested a review September 4, 2023 13:18
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit acd050d into shipwright-io:main Sep 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants