Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 20th, 2022 Community Meeting #92

Closed
SaschaSchwarze0 opened this issue Jun 19, 2022 · 4 comments
Closed

June 20th, 2022 Community Meeting #92

SaschaSchwarze0 opened this issue Jun 19, 2022 · 4 comments

Comments

@SaschaSchwarze0
Copy link
Member

  • Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
  • Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
  • (optional) Paste the image of an animal 😸
@SaschaSchwarze0
Copy link
Member Author

What's your thought on label propagation, see ship #86?

I think we should propagate from build strategy, build and buildrun. Annotations we only propagate from build strategy because they can cause behavior changes. Labels should not be used for behavior by controllers (though Istio for example does), their use case mainly is filtering and that makes a lot sense for build users.

fyi @Pinola

🦛

@SaschaSchwarze0
Copy link
Member Author

I think we can close SHIP-0003: Tekton Custom Task #9 because it is included in the trigger ship.

🐥

@otaviof
Copy link
Member

otaviof commented Jun 20, 2022

Gentle reminder on PR #1008, please review! 🙏

@SaschaSchwarze0
Copy link
Member Author

Minutes:

Label propagation

  • Asking for additional reviews

Old custom task ship

  • We decided to close it

API PR review

  • Sascha will take a look in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants