-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add kubectl explain #116
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @routerhan. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is coming from Ching(IBM intern) that is working with us, fyi @sbose78 |
/ok-to-test |
and @otaviof could you add folks to the whitelist please? |
Thank you Ching! Could you please confirm that this would not be overwritten by |
Hi @routerhan , If you run the Let us search and ask first if we can add a property in api spec to auto generate this property in CRD. I didn't find a good solution, but there are some discussions, like this: I think you can also help investigate or ask in community how to do that. |
I opened a new issue to ask about if |
@routerhan seems you got a nice response in operator-framework/operator-sdk#2886 (comment) , pls take a look |
According to the response, we are not able to set See more about the |
This PR enables the
kubectl explain
ofbuild
andbuildrun
resources, by adding thepreserveUnknownFields
property in CRD spec respectively.The standard output would be as following : (e.g.
buildrun
)