Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to amqp 1.x? #70

Open
ku1ik opened this issue Jan 29, 2019 · 4 comments
Open

Upgrade to amqp 1.x? #70

ku1ik opened this issue Jan 29, 2019 · 4 comments

Comments

@ku1ik
Copy link

ku1ik commented Jan 29, 2019

The amqp version used (0.3.1) is quite old, and is starting to give conflicts with other libs.

It seems there's not much work needed according to this upgrade guide: https://github.com/pma/amqp/wiki/Upgrade-from-0.X-to-1.0

I'd be happy to work on PR if you're interested.

@tomtaylor
Copy link

@sickill did you get anywhere with this? I can’t use Task Bunny at the moment due to a library conflict in an older version of rabbit_common, so I’d love to see this fixed in. Can I help?

@ku1ik
Copy link
Author

ku1ik commented Mar 9, 2019

@tomtaylor I managed to use task_bunny with with amqp 0.3.1 in my project for now. I haven't approached the upgrade yet but I'd like to do it.

I'm not sure when I'll get to this, but if you happen to have a patch I'd be happy to test.

@rraub
Copy link

rraub commented Apr 12, 2019

Another reason to upgrade: It would add support for AmazonMQ, since it currently only supports amqp v1.0. You could add AmazonMQ to the list of Supported Backends in the readme.

@AdrianSchneider
Copy link

Warning: version 1.0 of the amqp elixir library unfortunately has no compatibility of AMQP 1.0 the protocol. Just lost some trying to figure out Amazon MQ compatibility and am not seeing any good options yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants