Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail to build with gcc-14 (-Werror=implicit-function-declaration) #573

Open
orlitzky opened this issue Sep 15, 2024 · 2 comments
Open

Comments

@orlitzky
Copy link

With gcc-14, implicit function definitions have become an error by default. There are a few of these in the test suite:

/home/mjo/src/sleef.git/src/libm-tester/tester2simdsp.c: In function 'main':
/home/mjo/src/sleef.git/src/libm-tester/tester2simdsp.c:895:54: error: implicit declaration of function 'isinff' [-Wimplicit-function-declaration]
  895 |           (d >=  sqrt(FLT_MAX) && !(u0 <= 1.0001 || (isinff(t) && t > 0))) ||
/home/mjo/src/sleef.git/src/libm-tester/tester2ld.c: In function 'countULP':
/home/mjo/src/sleef.git/src/libm-tester/tester2ld.c:56:7: error: implicit declaration of function 'isnanl' [-Wimplicit-function-declaration]
   56 |   if (isnanl(c2) && isnanl(d)) return 0;
/home/mjo/src/sleef.git/src/libm-tester/tester2sp.c: In function 'main':
/home/mjo/src/sleef.git/src/libm-tester/tester2sp.c:657:54: error: implicit declaration of function 'isinff' [-Wimplicit-function-declaration]
  657 |           (d >=  sqrt(FLT_MAX) && !(u0 <= 1.0001 || (isinff(t) && t > 0))) ||

I copy/pasted some things to get it working, but usually the issue comes down to a missing #include.

@blapie
Copy link
Collaborator

blapie commented Sep 16, 2024

Hello! Thanks for reporting the error. We can probably easily reproduce locally and surely fix these missing includes.

Btw Gcc 14 is not officially supported in SLEEF yet, so there might be other issues. It probably won't be tested (in CI) unless it can be apt installed from the distributions available via github-hosted runners.

@orlitzky
Copy link
Author

No problem, both sleef-3.6.1 and gcc-14 are available in Gentoo so our users are testing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants