Clang on Windows and GNU ABI #525
Comments
joeramsay
added a commit
to joeramsay/sleef
that referenced
this issue
Jul 12, 2024
Previously SLEEF_BUILD_GNUABI_LIBS was silently ignored except for a small number of targets, or if the compiler does not support weak aliases. It can now be built regardless of OS and compiler on AArch64 and x86_64 - trying to enable it on any other target is now an error. The GLIBC *_finite symbols are handled using the same workaround as is used for the DALIAS macro when compiling on a target which does not support aliases. Though in practice these symbols are unlikely to be required on systems where aliases are unsupported, they are part of the API so need adding, if just to make the tests build. Also removed two CMake variables: - ENABLE_ALIAS, which was unused - ENABLE_GNUABI, which was now redundant but could still be forced on, leading to cryptic build failures Both names are still used by the preprocessor in sleefsimd* sources for managing names and aliases.
blapie
pushed a commit
that referenced
this issue
Jul 17, 2024
* Enable GNUABI build on more targets #525 Previously SLEEF_BUILD_GNUABI_LIBS was silently ignored except for a small number of targets, or if the compiler does not support weak aliases. It can now be built regardless of OS and compiler on AArch64 and x86_64 - trying to enable it on any other target is now an error. The GLIBC *_finite symbols are handled using the same workaround as is used for the DALIAS macro when compiling on a target which does not support aliases. Though in practice these symbols are unlikely to be required on systems where aliases are unsupported, they are part of the API so need adding, if just to make the tests build. Also removed two CMake variables: - ENABLE_ALIAS, which was unused - ENABLE_GNUABI, which was now redundant but could still be forced on, leading to cryptic build failures Both names are still used by the preprocessor in sleefsimd* sources for managing names and aliases. * Fix masked GNUABI build for NOALIAS Masked symbols also need to sidestep aliases when they are not supported. * Disable GNUABI for unsupported targets in precommit Default is on, but this setting was previously just ignored when unsupported. Disable it in the failing pipelines.
blapie
pushed a commit
to blapie/sleef
that referenced
this issue
Aug 2, 2024
* Enable GNUABI build on more targets shibatch#525 Previously SLEEF_BUILD_GNUABI_LIBS was silently ignored except for a small number of targets, or if the compiler does not support weak aliases. It can now be built regardless of OS and compiler on AArch64 and x86_64 - trying to enable it on any other target is now an error. The GLIBC *_finite symbols are handled using the same workaround as is used for the DALIAS macro when compiling on a target which does not support aliases. Though in practice these symbols are unlikely to be required on systems where aliases are unsupported, they are part of the API so need adding, if just to make the tests build. Also removed two CMake variables: - ENABLE_ALIAS, which was unused - ENABLE_GNUABI, which was now redundant but could still be forced on, leading to cryptic build failures Both names are still used by the preprocessor in sleefsimd* sources for managing names and aliases. * Fix masked GNUABI build for NOALIAS Masked symbols also need to sidestep aliases when they are not supported. * Disable GNUABI for unsupported targets in precommit Default is on, but this setting was previously just ignored when unsupported. Disable it in the failing pipelines.
blapie
pushed a commit
to blapie/sleef
that referenced
this issue
Aug 2, 2024
* Enable GNUABI build on more targets shibatch#525 Previously SLEEF_BUILD_GNUABI_LIBS was silently ignored except for a small number of targets, or if the compiler does not support weak aliases. It can now be built regardless of OS and compiler on AArch64 and x86_64 - trying to enable it on any other target is now an error. The GLIBC *_finite symbols are handled using the same workaround as is used for the DALIAS macro when compiling on a target which does not support aliases. Though in practice these symbols are unlikely to be required on systems where aliases are unsupported, they are part of the API so need adding, if just to make the tests build. Also removed two CMake variables: - ENABLE_ALIAS, which was unused - ENABLE_GNUABI, which was now redundant but could still be forced on, leading to cryptic build failures Both names are still used by the preprocessor in sleefsimd* sources for managing names and aliases. * Fix masked GNUABI build for NOALIAS Masked symbols also need to sidestep aliases when they are not supported. * Disable GNUABI for unsupported targets in precommit Default is on, but this setting was previously just ignored when unsupported. Disable it in the failing pipelines.
joeramsay
added a commit
to joeramsay/sleef
that referenced
this issue
Sep 16, 2024
Only Linux supports the AArch64 vector ABI, so it doesn't make sense to expose these symbols anywhere else for AArch64. Without any compelling reason to provide them on x86_64, it is better to just revert this patch and deal with this more carefully after the release. This reverts commit 0e47fcc.
blapie
pushed a commit
that referenced
this issue
Sep 17, 2024
Only Linux supports the AArch64 vector ABI, so it doesn't make sense to expose these symbols anywhere else for AArch64. Without any compelling reason to provide them on x86_64, it is better to just revert this patch and deal with this more carefully after the release. This reverts commit 0e47fcc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the build system is special-cased for clang on windows (using SLEEF_CLANG_ON_WINDOWS variable).
Most of these cases make sense, but in Configure.cmake we do not able GNUABI if SLEEF_CLANG_ON_WINDOWS and nothing seems to justify/explain it.
What is wrong with Clang on Windows and GNU ABI?
Remember at the time windows also implied x86, but soon it won't.
The text was updated successfully, but these errors were encountered: