-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RVV inline header generation #487
Comments
It's not going to be that trivial as there are conflicting types between SP and DP modes. For example, the following:
I don't really understand how to fix that up. Please find my WIP at master...rivosinc:sleef:fix-rvv-inline-headers |
blapie
added a commit
to blapie/sleef
that referenced
this issue
Feb 8, 2024
Macs do not implement SVE yet and Darwin does not support it. Should solve shibatch#425 and shibatch#487.
@luhenry Can we close this one? I think we are way past that now? |
Yes, it's all working now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just noticed I missed something while reviewing the RVV port. In order to make the inline header file work you need to add an extra line after (almost) each macro so it can be processed correctly.
See the examples in this patch: https://github.com/shibatch/sleef/pull/283/files#diff-ef9773efa1e59a8749e0e62f58bbe5971cce560eeebbc5918601099cb11a5457
Then hopefully you can switch the tests back on in the workflow file.
@luhenry Would you mind having a look at this?
The text was updated successfully, but these errors were encountered: