Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-push hook doesn't work in xcode #33

Open
kjing opened this issue May 18, 2020 · 3 comments
Open

pre-push hook doesn't work in xcode #33

kjing opened this issue May 18, 2020 · 3 comments

Comments

@kjing
Copy link

kjing commented May 18, 2020

Hi,
we try to use Komondor to set up a pre-push hook to run swiftlint before pushing any changes in an IOS project. For some reason, the pre-push hook doesn't work in xcode(11.4.1), xcode allow a push without running swiftlint. The same config and same project, it works fine in the command line "git push". Also, in other IDE, vscode or tower. It does block push with a general error without showing the linting error. any idea why? Is it a known issue in xcode?

@orta
Copy link
Member

orta commented May 19, 2020

perhaps they use libgit and that doesn't trigger hooks?

@kjing
Copy link
Author

kjing commented May 19, 2020

@orta thanks for your response. likely it doesn't trigger any hooks in xcode. also, in vscode or tower, it does trigger pre-push hook, but just give general error message without any linting error. It will confuse users.

@orta
Copy link
Member

orta commented May 19, 2020

You're welcome to look into getting them working 👍 - I just use git, and this technique comes over from ruby/node land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants