Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karsar - transfer() will always revert for token that not return boolean value #40

Open
sherlock-admin3 opened this issue Oct 21, 2024 · 0 comments

Comments

@sherlock-admin3
Copy link
Contributor

sherlock-admin3 commented Oct 21, 2024

karsar

Medium

transfer() will always revert for token that not return boolean value

Summary

In this case, if USDT is used as a rewards token, the transfer functions will always fail because USDT does not have a boolean value.

Root Cause

in MorphoLeverageStrategyExtension:603 uses transfer()
inMorphoLeverageStrategyExtension:1238uses transfer()

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

transfer() will always revert for token that not return

PoC

No response

Mitigation

Use safeTransfer() instead of transfer() .

@sherlock-admin2 sherlock-admin2 changed the title Lone Rosewood Platypus - transfer() will always revert for token that not return boolean value karsar - transfer() will always revert for token that not return boolean value Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant