Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nikhilx0111 - protcol is not compatible with morpho #38

Open
sherlock-admin4 opened this issue Oct 21, 2024 · 0 comments
Open

nikhilx0111 - protcol is not compatible with morpho #38

sherlock-admin4 opened this issue Oct 21, 2024 · 0 comments

Comments

@sherlock-admin4
Copy link
Contributor

sherlock-admin4 commented Oct 21, 2024

nikhilx0111

High

protcol is not compatible with morpho

Summary

the integration of MorphoLeverageModule.sol is not compatible with morpho due to incorrect function paramters as a result the protocol is not compatible with morpho

the parameteres expected by morpho
https://docs.morpho.org/morpho/contracts/morpho#:~:text=MarketParams%20struct%E2%80%8B,the%20bytes32%20id.

however the current function has different parameters

https://github.com/sherlock-audit/2024-10-morpho-x-index/blob/2f125406e0dd3b1fc029b9a47fe97bfbf906fce2/index-protocol/contracts/protocol/modules/v1/MorphoLeverageModule.sol#L765C3-L777C6

https://github.com/sherlock-audit/2024-10-morpho-x-index/blob/2f125406e0dd3b1fc029b9a47fe97bfbf906fce2/index-protocol/contracts/protocol/integration/lib/Morpho.sol#L101-L119

Root Cause

https://github.com/sherlock-audit/2024-10-morpho-x-index/blob/2f125406e0dd3b1fc029b9a47fe97bfbf906fce2/index-protocol/contracts/protocol/integration/lib/Morpho.sol#L101-L119

https://github.com/sherlock-audit/2024-10-morpho-x-index/blob/2f125406e0dd3b1fc029b9a47fe97bfbf906fce2/index-protocol/contracts/protocol/modules/v1/MorphoLeverageModule.sol#L765C3-L777C6

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

the protocol is incompatible with morpho

PoC

No response

Mitigation

adapt to the specific functions of morpho

@sherlock-admin2 sherlock-admin2 changed the title Breezy Basil Toad - protcol is not compatible with morpho nikhilx0111 - protcol is not compatible with morpho Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant