Skip to content

Latest commit

 

History

History
41 lines (22 loc) · 1.34 KB

024.md

File metadata and controls

41 lines (22 loc) · 1.34 KB
Raw

Winning Strawberry Salmon

Medium

Removed addresses should not be able to call archiveProfile(), restoreProfile(), or uninviteUser().

Summary

Removed addresses have excessive permissions; they can continue to operate on profile information, delete inviters, and close/reopen profiles.

Root Cause

The archiveProfile(), restoreProfile(), and uninviteUser() functions lack the checkIfCompromised(address) modifier.

https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/EthosProfile.sol#L258 https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/EthosProfile.sol#L330 https://github.com/sherlock-audit/2024-10-ethos-network/blob/main/ethos/packages/contracts/contracts/EthosProfile.sol#L349

Internal pre-conditions

No response

External pre-conditions

There are removed accounts present in the Profile.

Attack Path

Removed addresses can affect the profile status by calling archiveProfile(), restoreProfile(), and uninviteUser() functions

Impact

Removed addresses can affect the profile status by calling archiveProfile(), restoreProfile(), and uninviteUser() functions

PoC

No response

Mitigation

add the checkIfCompromised(invitee) modifier to the archiveProfile(), restoreProfile(), and uninviteUser() functions