Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bareli - no access control on executeProposal #245

Open
sherlock-admin3 opened this issue Sep 23, 2024 · 0 comments
Open

bareli - no access control on executeProposal #245

sherlock-admin3 opened this issue Sep 23, 2024 · 0 comments

Comments

@sherlock-admin3
Copy link

sherlock-admin3 commented Sep 23, 2024

bareli

Medium

no access control on executeProposal

Summary

There is no access control on executeProposal.

Vulnerability Detail

function executeProposal(uint256 proposalID) external {
(bool finished, bool passed, ) = proposalStatus(proposalID);
require(!finished, "voting has ended");
require(passed, "proposal has not been passed yet");

    _executeProposal(proposalID);
}

Impact

anyone can call this function to execute any proposalID

Code Snippet

https://github.com/sherlock-audit/2024-08-morphl2/blob/main/morph/contracts/contracts/l2/staking/Gov.sol#L190

Tool used

Manual Review

Recommendation

use onlyowner

@sherlock-admin3 sherlock-admin3 changed the title Skinny Licorice Ostrich - no access control on executeProposal bareli - no access control on executeProposal Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant