You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
function executeProposal(uint256 proposalID) external {
(bool finished, bool passed, ) = proposalStatus(proposalID);
require(!finished, "voting has ended");
require(passed, "proposal has not been passed yet");
_executeProposal(proposalID);
}
Impact
anyone can call this function to execute any proposalID
The text was updated successfully, but these errors were encountered:
sherlock-admin3
changed the title
Skinny Licorice Ostrich - no access control on executeProposal
bareli - no access control on executeProposal
Oct 16, 2024
bareli
Medium
no access control on executeProposal
Summary
There is no access control on executeProposal.
Vulnerability Detail
function executeProposal(uint256 proposalID) external {
(bool finished, bool passed, ) = proposalStatus(proposalID);
require(!finished, "voting has ended");
require(passed, "proposal has not been passed yet");
Impact
anyone can call this function to execute any proposalID
Code Snippet
https://github.com/sherlock-audit/2024-08-morphl2/blob/main/morph/contracts/contracts/l2/staking/Gov.sol#L190
Tool used
Manual Review
Recommendation
use onlyowner
The text was updated successfully, but these errors were encountered: