From b60efcc8cb2c91d4eb3ec3994ab6ddb5b25f3616 Mon Sep 17 00:00:00 2001 From: Adrian Goh Jun Wei Date: Sat, 6 Jul 2024 11:35:58 +0800 Subject: [PATCH] upgrade actions/setup-node to v4 (#497) * upgrade actions/setup-node to v4 * Fix tests uninitialized constant rack (#501) * fix: manually insert shakapacker using "echo" instead * manually overwrite "rack" to be v2 * update changelog --- .github/workflows/dummy.yml | 2 +- .github/workflows/node.yml | 2 +- CHANGELOG.md | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dummy.yml b/.github/workflows/dummy.yml index 075cab6c..c177dbda 100644 --- a/.github/workflows/dummy.yml +++ b/.github/workflows/dummy.yml @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v4 with: persist-credentials: false - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: '16' - uses: ruby/setup-ruby@v1 diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index 8db81e13..90047ee1 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -44,7 +44,7 @@ jobs: with: persist-credentials: false - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} cache: yarn diff --git a/CHANGELOG.md b/CHANGELOG.md index 2af053ff..4c44c212 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,9 @@ _next_ branch is for v8 changes ## [Unreleased] Changes since the last non-beta release. +### Changed +- Update outdated GitHub Actions to use Node.js 20.0 versions instead [PR 497](https://github.com/shakacode/shakapacker/pull/497) by [adriangohjw](https://github.com/adriangohjw). + ### Fixed - Fixes failing tests for Ruby 2.7 due to `Rack::Handler::Puma.respond_to?(:config)` [PR 501](https://github.com/shakacode/shakapacker/pull/501) by [adriangohjw](https://github.com/adriangohjw)