Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply promisify() to fs module functions to avoid error with Serverless v4 #1917

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Apply promisify() to fs module functions to avoid error with Serverless v4 #1917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/packageModules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ const semver = require('semver');
const fs = require('fs');
const { getAllNodeFunctions, isProviderGoogle } = require('./utils');

const readFileAsync = BbPromise.promisify(fs.readFile);
const statAsync = BbPromise.promisify(fs.stat);

function setArtifactPath(funcName, func, artifactPath) {
const version = this.serverless.getVersion();

Expand Down Expand Up @@ -90,8 +93,8 @@ function getFileContentAndStat(directory, filePath) {

return BbPromise.all([
// Get file contents and stat in parallel
fs.readFileAsync(fullPath),
fs.statAsync(fullPath)
readFileAsync(fullPath),
statAsync(fullPath)
]).then(
result => ({
data: result[0],
Expand Down