Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions for vars defaults #5

Open
raffaelj opened this issue Oct 20, 2018 · 2 comments
Open

suggestions for vars defaults #5

raffaelj opened this issue Oct 20, 2018 · 2 comments

Comments

@raffaelj
Copy link

assets.path doesn't exist anywhere in the cockpit code. Was it in a previous version or did you add it by mistake?

'finder.allowed_uploads' => 10, looks like a placeholder. The default could be a list with "save" file types, like: pdf, png, jpg, jpeg, svg, gif

@serjoscha87
Copy link
Owner

assets.path doesn't exist anywhere in the cockpit code. Was it in a previous version or did you add it by mistake?

I dont know where I got this from but there are still remains according to that within the cockpit code:
https://github.com/agentejo/cockpit/search?q=assets.path&unscoped_q=assets.path


'finder.allowed_uploads' => 10, looks like a placeholder. The default could be a list with "save" file types, like: pdf, png, jpg, jpeg, svg, gif

I dont get what you mean by this.
"finder.allowed_uploads" is nothing that was defined by me but rather a cockpit property I found in the code: https://github.com/agentejo/cockpit/search?q=finder.allowed_uploads&unscoped_q=finder.allowed_uploads

@raffaelj
Copy link
Author

raffaelj commented Oct 23, 2018

I dont know where I got this from but there are still remains according to that within the cockpit code:

I'm not 100% sure about this. I just did a search for "assets.path" in the cockpit dir and there was no result.
There are some dynamic "asset.path", but they aren't related to any global setting. The constant ASSETS_URL is set in bootstrap.php and can be adjusted in config.yaml with
edit: no, this is to adjust the assets dir for layout and .js files

paths:
    assets: custom/assets/path

I dont get what you mean by this.

allowed_uploads exists since 18th Aug to prevent uploading executible files through the finder and the assets manager: agentejo/cockpit#839 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants