Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for namingStrategy request attribute #69

Open
pditommaso opened this issue May 20, 2024 · 7 comments · Fixed by #71
Open

Add support for namingStrategy request attribute #69

pditommaso opened this issue May 20, 2024 · 7 comments · Fixed by #71
Assignees
@munishchouhan

Comments

@pditommaso
Copy link
Contributor

The goal of this issue is to support the naming strategy request attribute in the wave CLI.

This could be now implemented via nameStrategy attribute.
@pditommaso pditommaso mentioned this issue May 20, 2024
Closed
@munishchouhan munishchouhan linked a pull request May 21, 2024 that will close this issue
add --name-strategy to wave cli #71
Merged
@pditommaso pditommaso reopened this May 21, 2024
@pditommaso
Copy link
Contributor Author

pditommaso commented May 21, 2024 •
edited
Loading

Trying this with

wave --conda cowpy --freeze --build-repo docker.io/pditommaso/wave-test --dry-run --name-strategy imageSuffix

it returns

docker.io/pditommaso/wave-test:cowpy--687bcba781ef4f5d

instead it should be

docker.io/pditommaso/wave-test/cowpy:687bcba781ef4f5d

tho it may be a backend problem

@munishchouhan
Copy link
Member

I will check it out

@munishchouhan
Copy link
Member

I tested it through API call got the same think:
Screenshot 2024-05-21 at 22 42 25

@munishchouhan
Copy link
Member

but while testing i found another issue
pr for fix:
#72

@pditommaso
Copy link
Contributor Author

Still not working in my tests

#69 (comment)

@munishchouhan
Copy link
Member

Still not working in my tests

#69 (comment)

yes, because its an issue in backend
I tried using wave API #69 (comment)
and got the same result as #69 (comment)

I will open an issue in wave to fix it

@munishchouhan munishchouhan mentioned this issue May 22, 2024
Closed
@munishchouhan
Copy link
Member

issue created
seqeralabs/wave#507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munishchouhan munishchouhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add --name-strategy to wave cli seqeralabs/wave-cli
2 participants
@pditommaso @munishchouhan