Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ciso646 is deprecated #3302

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[FIX] ciso646 is deprecated #3302

merged 1 commit into from
Nov 7, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Nov 7, 2024

gcc-mirror/gcc@5c34f02#diff-62a23e8a5ebebf0690390ca9d369d4a79f6e85ffc00712f521ebcd0206a62dbc

#if __cplusplus >= 202002L && ! _GLIBCXX_USE_DEPRECATED
#  error "<ciso646> is not a standard header in C++20, use <version> to detect implementation-specific macros"
#elif __cplusplus >= 201703L && defined __DEPRECATED
#  pragma GCC diagnostic push
#  pragma GCC diagnostic ignored "-Wc++23-extensions"
#  warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros"
#  pragma GCC diagnostic pop
#endif

Errors on nightly gcc trunk builds

<version> makes both __GLIBCXX__ and _LIBCPP_VERSION available

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (77db997) to head (5a373da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3302   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         271      271           
  Lines       11948    11948           
  Branches      104      104           
=======================================
  Hits        11725    11725           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3302

@eseiler eseiler merged commit eabcac1 into seqan:main Nov 7, 2024
42 checks passed
@eseiler eseiler deleted the fix/ciso646 branch November 7, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants