Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Simplify #77

Merged
merged 2 commits into from
Mar 13, 2024
Merged

[INFRA] Simplify #77

merged 2 commits into from
Mar 13, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Mar 11, 2024

  • datasources: Auto add everything in test/data
  • datasources: Add example for external datasource (download)
  • above: needed?
  • Do we need interface + lib?
  • more cleanup :)
  • simplify CI/make things optional (e.g., coverage)

Questions regarding output:

  • bin is empty, binary is in build directory
  • lib is not empty, gtest is there. app-template lib is in build directory

Is this OK, or would it be better to do bin/lib output dirs again?

Current output:

As picture Click

tempsnip

As text Click
~/develop/app-template/build/GCC-13-Debug$ tree -L 2
.
├── CMakeCache.txt
├── CMakeFiles
│   ├── 3.28.3
│   ├── [...]
│   └── progress.marks
├── CPM_modules
│   ├── FindGTest.cmake
│   ├── Findcereal.cmake
│   ├── Findhibf.cmake
│   ├── Findseqan3.cmake
│   ├── Findsharg.cmake
│   ├── Findsimde.cmake
│   └── Findyaml-cpp.cmake
├── CTestTestfile.cmake
├── Makefile
├── _deps
│   ├── cereal-build
│   ├── gtest-build
│   ├── hibf-build
│   ├── seqan3-build
│   ├── sharg-build
│   ├── tdl-build
│   ├── tdl-subbuild
│   └── yaml-cpp-build
├── app-template
├── bin
├── cmake_install.cmake
├── compile_commands.json
├── cpm-package-lock.cmake
├── lib
│   ├── libgtest.a
│   └── libgtest_main.a
├── libapp-template_lib.a
└── test
    ├── CMakeFiles
    ├── CTestTestfile.cmake
    ├── Makefile
    ├── Testing
    ├── _datasources
    ├── api_fastq_coversion_test
    ├── cli_fastq_coversion_test
    ├── cmake_install.cmake
    ├── data
    └── output

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2d6439a) to head (0fb8d58).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           28        28           
=========================================
  Hits            28        28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CMakeLists.txt Outdated Show resolved Hide resolved
@eseiler eseiler marked this pull request as ready for review March 12, 2024 13:03
@eseiler eseiler requested review from SGSSGene and smehringer and removed request for SGSSGene and smehringer March 12, 2024 13:06
@eseiler eseiler merged commit 110c346 into seqan:main Mar 13, 2024
12 checks passed
@eseiler eseiler deleted the infra/simplify branch March 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants