Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-rabbitmq-node-health.rb check bug #69

Closed
rocdove opened this issue Jul 6, 2017 · 7 comments
Closed

check-rabbitmq-node-health.rb check bug #69

rocdove opened this issue Jul 6, 2017 · 7 comments

Comments

@rocdove
Copy link

rocdove commented Jul 6, 2017

in node_healthy! func
# Parse our json data
nodeinfo = JSON.parse(resource.get)[0]
only get the first node info is incomplete.
Singleton rabbitmq node is OK. when rabbitmq cluster,will not normal working.

@rocdove
Copy link
Author

rocdove commented Jul 6, 2017

def node_healthy?
...
JSON.parse(resource.get).each do |nodeinfo|
# do something check
...
end
...
end

this will be well.

@majormoses majormoses added the Bug label Jul 6, 2017
@majormoses
Copy link
Member

@rocdove thanks for the report, would you be willing to submit a pr to fix this?

@rocdove
Copy link
Author

rocdove commented Jul 6, 2017

Let me try.

@rocdove
Copy link
Author

rocdove commented Jul 6, 2017

@majormoses Please give some advice for this commit. THX!

@majormoses
Copy link
Member

@rocdove when I have some time absolutely.

@majormoses
Copy link
Member

@rocdove overall it seems reasonable looking at the code just some minor tweaks. When you are ready create a PR:

  • make sure to add a CHANGELOG entry under unreleased
  • a testing artifact is provided, if not a unit test then a gist/screenshot with the input and output so we know it works.

I do use RMQ cluster for sensu so I will pull your code and try to test tomorrow.

@majormoses
Copy link
Member

@rocdove realized this was already reported awhile go: #43 I think we should close this and continue any further discussions over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants