Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache licenses #47

Open
UTurista opened this issue Mar 25, 2024 · 1 comment
Open

Cache licenses #47

UTurista opened this issue Mar 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@UTurista
Copy link

UTurista commented Mar 25, 2024

Problem

With projects that depend on many libraries we may hit the same license URL a lot of times.

In fact, with some combinations, we may hit the same URL so many times that we trigger 429 errors and we fail to download the actual license.

Proposed solution

Cache the URL->License response combo, then when another package attempts to download from the same source we simply use the cached file.

@sensslen
Copy link
Owner

sensslen commented Mar 25, 2024

@UTurista thanks for the suggestion. For now this feature is not planned. Actually the current code only downloads the source once per package. However feel free to work on an improvement that caches the licenses....

@sensslen sensslen added the enhancement New feature or request label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants