Fix pending after first message #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhyoungRyu
reviewed
Jul 27, 2023
src/hooks/useCreateGroupChannel.ts
Outdated
Comment on lines
52
to
56
| let count = 0; | ||
| while (groupChannel.lastMessage == null && count < 30) { | ||
| await delay(100); | ||
| count += 1; | ||
| } |
There was a problem hiding this comment.
nit;
async function waitForLastMessage(groupChannel, maxRetries = 30, retryInterval = 100) {
let count = 0;
while (groupChannel.lastMessage == null && count < maxRetries) {
await delay(retryInterval);
count++;
}
await delay(500);
}
How about having this logic separately and call it in here?
// usage
await waitForLastMessage(groupChannel);
There was a problem hiding this comment.
@AhyoungRyu Your suggestion is also good. Could you update it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add detailed waiting logic for the issue that Bot's message is pending after sending the first message
How to
Add logic to wait until the last message to the group channel is not null (up to 3 seconds) because it determines that an error occurs when the channel loads immediately after sending a message to the group channel