Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superhero active hover menu items color stays dark #21

Open
mojave27 opened this issue May 30, 2018 · 1 comment
Open

superhero active hover menu items color stays dark #21

mojave27 opened this issue May 30, 2018 · 1 comment

Comments

@mojave27
Copy link

Greetings and thanks for the great themes. I tried out the superhero theme with semantic-ui-react, and it looks awesome. However, there is an issue with the styling of some items, where the font color would be black on a #333 background-color.

I initially noticed it on a Dropdown menu item (the Electronics item is hovered in this image):
screen shot 2018-05-28 at 3 42 40 pm

The Dropdown is nested in a Menu.

When I viewed the demo of the superhero theme on http://semantic-ui-forest.com/themes/bootswatch/superhero/, the dropdown menu's hovered items had white font.

If I remove the Menu parent component, the Dropdown is styled correctly. I tried a few things, including downgrading semantic-ui from 2.3.1 to 2.2.0, but ultimately just downloaded the semantic.superhero.min.css and replaced the one in my dist/ folder, and it corrected the problem locally.

Using the css from the demo site:
screen shot 2018-05-29 at 9 13 11 pm

I used create-react-app to initialize my react app. I have the semantic.superhero.min.css file in src/semantic/dist, and I import that into my src/index.js. I'm not applying any other css. Here are my dependencies:

"dependencies": {
   "ajv": "^6.0.0",
   "react": "^15.4.2",
   "react-dom": "^15.4.2",
   "react-router": "^3.0.0",
   "react-scripts": "1.1.4",
   "semantic-ui-react": "^0.80.2"
 },
 "devDependencies": {
   "gulp": "^3.9.1",
   "semantic-ui": "^2.3.1"
 }

I don't know if the problem is related to my build of the css or not. But, if I can track down the root cause, I'll report back.

@xiaohanyu
Copy link
Member

Thanks for your report. Will work on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants