Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting notified that publish fails even when build succeeds (better alternative to || true) #332

Open
jedwards1211 opened this issue Apr 11, 2020 · 0 comments

Comments

@jedwards1211
Copy link
Contributor

jedwards1211 commented Apr 11, 2020

So the readme says setup will use the command semantic-release || true for CircleCI...
But it sucks to realize a month later that a build failed to publish even though it passed.

When you think about it, the || true seems questionable on its face. I forget why it's recommended but I'm guessing semantic-release has a nonzero exit code when the branch is excluded.

I think there should be a CLI flag to suppress the nonzero exit code when appropriate, so that we can avoid using || true.

EDIT: Just realized I'm on version 15, maybe semantic-release 17 notifies us if the release is failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant