Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large clipboard data freezes all input #43

Closed
ehfd opened this issue Aug 21, 2022 · 2 comments
Closed

Large clipboard data freezes all input #43

ehfd opened this issue Aug 21, 2022 · 2 comments
Labels
bug Something isn't working transport Underlying media or data transport protocols

Comments

@ehfd
Copy link
Member

ehfd commented Aug 21, 2022

INFO:webrtc_input:sending clipboard content, length: 49194
0:05:03.202935604   197 0x7f0f90002b80 WARN       webrtcdatachannel webrtcdatachannel.c:264:_channel_store_error:<WebRTCDataChannel@0x1e04db0> Error: Requested to send a string that is too large
0:05:03.203222887   197 0x7f0f980022a0 WARN       webrtcdatachannel datachannel.c:449:gst_webrtc_data_channel_on_error:<WebRTCDataChannel@0x1e04db0> Error: Requested to send a string that is too large
TypeError: <lambda>() takes 1 positional argument but 2 were given
WARNING:gstwebrtc_app:unhandled on_data_close

To reproduce: Ctrl+C anything that is sufficiently long. All input becomes impossible until session is reloaded.

@ehfd
Copy link
Member Author

ehfd commented Aug 25, 2022

Should set a maximum on clipboard length and don't send it if so.
Else, the exception should be handled gracefully.
Relevant code: https://github.com/selkies-project/selkies-gstreamer/blob/v1.3.1/src/selkies_gstreamer/gstwebrtc_app.py#L753

@ehfd ehfd added bug Something isn't working transport Underlying media or data transport protocols labels Oct 12, 2022
ehfd added a commit that referenced this issue Jan 18, 2023
* [DOCS] Cleanup docs and instructions

* Patch clipboard freeze issue (Issue #43)
@ehfd
Copy link
Member Author

ehfd commented Jan 18, 2023

Patched by #73.

HOWEVER, For this issue to be really fixed, we need to implement DataChannel chunking. This is moved over to issue #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transport Underlying media or data transport protocols
Projects
None yet
Development

No branches or pull requests

1 participant