Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard keystrokes continue to be held when packets are lost by congestion or unstable connection / Improve the last bit of keyboard latency overall while accommodating unstable connections #145

Open
ehfd opened this issue May 1, 2024 · 3 comments · Fixed by #146
Labels
bug Something isn't working enhancement New feature or request interface OS input, display, or audio interfaces web Web components including gst-web

Comments

@ehfd
Copy link
Member

ehfd commented May 1, 2024

Keys continue to be held when packets are lost by congestion or unstable connection. This is because key presses are sent by signals when they are pressed and when they are down.

https://github.com/Xpra-org/xpra/blob/a5a13a993139d9d48a60734e7bab3ec9d53c919a/xpra/server/mixins/input.py#L257

The above is a good solution to this problem, to send key-repeat packets continuously when a key-press is made and when such packets stop, un-press from the host.

@ehfd ehfd added bug Something isn't working web Web components including gst-web interface OS input, display, or audio interfaces high-priority Must be addressed as soon as possible, remove when resolved labels May 1, 2024
@ehfd ehfd closed this as completed in #146 May 2, 2024
@ehfd ehfd removed the high-priority Must be addressed as soon as possible, remove when resolved label May 2, 2024
@ehfd
Copy link
Member Author

ehfd commented May 11, 2024

Reopening in order to consult other projects and reevaluate the solutions.

PRs have been reversed.

Various considerations including asynchronization are required.

@ehfd ehfd reopened this May 11, 2024
ehfd added a commit that referenced this issue May 11, 2024
@ehfd ehfd changed the title Keys continue to be held when packets are lost by congestion or unstable connection Keyboard keystrokes continue to be held when packets are lost by congestion or unstable connection / Improve Keyboard latency overall May 11, 2024
@ehfd ehfd changed the title Keyboard keystrokes continue to be held when packets are lost by congestion or unstable connection / Improve Keyboard latency overall Keyboard keystrokes continue to be held when packets are lost by congestion or unstable connection / Improve the last bit of keyboard latency overall May 11, 2024
@ehfd ehfd changed the title Keyboard keystrokes continue to be held when packets are lost by congestion or unstable connection / Improve the last bit of keyboard latency overall Keyboard keystrokes continue to be held when packets are lost by congestion or unstable connection / Improve the last bit of keyboard latency overall while accommodating unstable connections May 11, 2024
@ehfd
Copy link
Member Author

ehfd commented May 25, 2024

main...PMohanJ:selkies-gstreamer:keyboard-linked-list should be brought back after the v1.6.0 release. It must be ensured that there is no introduced latency to keystrokes.

@ehfd ehfd added the enhancement New feature or request label Jun 5, 2024
@ehfd
Copy link
Member Author

ehfd commented Jun 6, 2024

6a54bc7

In short, this is the reverse of this commit (ignoring README.md and gstwebrtc_app.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request interface OS input, display, or audio interfaces web Web components including gst-web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant