Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ casting and some fixes #1610

Merged
merged 2 commits into from
Oct 8, 2024
Merged

C++ casting and some fixes #1610

merged 2 commits into from
Oct 8, 2024

Conversation

lumiZGorlic
Copy link
Contributor

C style casts changed to C++ style casts, also some fixes and cosmetic changes

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (9130bf1) to head (cbad841).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
Packet++/src/SipLayer.cpp 80.76% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1610      +/-   ##
==========================================
+ Coverage   83.10%   83.11%   +0.01%     
==========================================
  Files         276      276              
  Lines       46889    46914      +25     
  Branches     9365     9374       +9     
==========================================
+ Hits        38965    38994      +29     
+ Misses       7065     7062       -3     
+ Partials      859      858       -1     
Flag Coverage Δ
fedora40 74.67% <83.33%> (-0.01%) ⬇️
macos-12 81.11% <84.37%> (+<0.01%) ⬆️
macos-13 80.53% <84.84%> (+0.07%) ⬆️
macos-14 80.46% <84.84%> (+<0.01%) ⬆️
mingw32 70.61% <81.48%> (-0.02%) ⬇️
mingw64 70.58% <81.48%> (-0.02%) ⬇️
npcap 84.99% <90.38%> (-0.03%) ⬇️
rhel94 74.56% <83.33%> (+<0.01%) ⬆️
ubuntu2004 57.94% <85.96%> (+0.01%) ⬆️
ubuntu2004-zstd 58.09% <85.96%> (+0.03%) ⬆️
ubuntu2204 74.48% <83.33%> (-0.04%) ⬇️
ubuntu2204-icpx 58.70% <66.66%> (-0.01%) ⬇️
ubuntu2404 74.76% <83.33%> (+0.01%) ⬆️
unittest 83.11% <92.42%> (+0.01%) ⬆️
windows-2019 85.03% <90.38%> (-0.03%) ⬇️
windows-2022 85.04% <90.38%> (-0.03%) ⬇️
winpcap 85.02% <90.38%> (ø)
xdp 49.65% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos
Copy link
Collaborator

@lumiZGorlic, thanks for the contribution. Let's fix the CI first. Please also make sure that you have read the contribution document.

@lumiZGorlic
Copy link
Contributor Author

Thanks, i read this document before but i got confused about some steps. I just pushed clang-format fixes so hope it'll pass OK now.

Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seladb seladb merged commit 7aba384 into seladb:dev Oct 8, 2024
40 checks passed
@seladb
Copy link
Owner

seladb commented Oct 8, 2024

Thank you @lumiZGorlic for your contribution, much appreciated! 🙏

fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants