-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ casting and some fixes #1610
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1610 +/- ##
==========================================
+ Coverage 83.10% 83.11% +0.01%
==========================================
Files 276 276
Lines 46889 46914 +25
Branches 9365 9374 +9
==========================================
+ Hits 38965 38994 +29
+ Misses 7065 7062 -3
+ Partials 859 858 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@lumiZGorlic, thanks for the contribution. Let's fix the CI first. Please also make sure that you have read the contribution document. |
Thanks, i read this document before but i got confused about some steps. I just pushed clang-format fixes so hope it'll pass OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @lumiZGorlic for your contribution, much appreciated! 🙏 |
C style casts changed to C++ style casts, also some fixes and cosmetic changes