Do not require C language to find_package libpcap #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1607 +/- ##
==========================================
+ Coverage 83.10% 83.11% +0.01%
==========================================
Files 276 276
Lines 46889 46907 +18
Branches 9365 9510 +145
==========================================
+ Hits 38965 38988 +23
+ Misses 7065 7061 -4
+ Partials 859 858 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
egecetin
approved these changes
Oct 5, 2024
clementperon
approved these changes
Oct 5, 2024
tigercosmos
approved these changes
Oct 5, 2024
clementperon
force-pushed
the
do_not_require_c
branch
from
398e5c8
to
3f5df0b
Compare
seladb
approved these changes
Oct 8, 2024
|
Thank you @kiwixz for working on this fix, much appreciated! 🙏 |
fxlb
pushed a commit
to fxlb/PcapPlusPlus
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1606.