Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CMake uninstall target #1183

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Aug 16, 2023

Fixes #1171

@tbhaxor tbhaxor requested a review from seladb as a code owner August 16, 2023 20:42
@tbhaxor tbhaxor changed the base branch from master to dev August 16, 2023 20:42
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1183 (24d4619) into dev (aa4e62d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1183      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.01%     
==========================================
  Files         156      156              
  Lines       20093    20093              
  Branches     7575     7575              
==========================================
- Hits        16499    16497       -2     
- Misses       3071     3074       +3     
+ Partials      523      522       -1     
Flag Coverage Δ
alpine315 68.55% <ø> (ø)
centos7 71.92% <ø> (-0.02%) ⬇️
fedora34 68.37% <ø> (ø)
macos-11 60.12% <ø> (ø)
macos-12 60.17% <ø> (ø)
macos-ventura 60.11% <ø> (-0.01%) ⬇️
mingw32 68.78% <ø> (-0.04%) ⬇️
mingw64 68.83% <ø> (-0.02%) ⬇️
npcap 82.14% <ø> (-0.05%) ⬇️
ubuntu1804 72.13% <ø> (-0.04%) ⬇️
ubuntu2004 69.23% <ø> (-0.01%) ⬇️
ubuntu2204 68.15% <ø> (-0.03%) ⬇️
ubuntu2204-icpx 59.17% <ø> (ø)
unittest 82.10% <ø> (-0.01%) ⬇️
windows-2019 82.18% <ø> (-0.02%) ⬇️
windows-2022 82.17% <ø> (-0.03%) ⬇️
winpcap 82.15% <ø> (-0.02%) ⬇️
zstd 72.01% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Owner

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tbhaxor for working on it! 🙏
I'm not a CMake expert so I'd like @clementperon to review before we merge this PR

README.md Outdated Show resolved Hide resolved
cmake/PcapPlusPlusUninstall.cmake.in Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@clementperon
Copy link
Collaborator

Hi @tbhaxor,

Thanks for your contribution! Just minor comments, let me know what you think.

CMakeLists.txt Outdated Show resolved Hide resolved
@seladb seladb merged commit 843765f into seladb:dev Aug 22, 2023
35 checks passed
@tbhaxor tbhaxor deleted the feature/cmake-uninstall branch August 22, 2023 02:12
fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to uninstall software built from source?
3 participants