-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CMake uninstall target #1183
Conversation
eb2c40b
to
c3520a6
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1183 +/- ##
==========================================
- Coverage 82.11% 82.10% -0.01%
==========================================
Files 156 156
Lines 20093 20093
Branches 7575 7575
==========================================
- Hits 16499 16497 -2
- Misses 3071 3074 +3
+ Partials 523 522 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tbhaxor for working on it! 🙏
I'm not a CMake expert so I'd like @clementperon to review before we merge this PR
Hi @tbhaxor, Thanks for your contribution! Just minor comments, let me know what you think. |
c3520a6
to
20bf75a
Compare
34a36a4
to
24d4619
Compare
Fixes #1171