Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Heap-buffer-overflow (read) in NflogTlv::getType #1163

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

@sashashura sashashura requested a review from seladb as a code owner July 21, 2023 12:34
@sashashura sashashura changed the base branch from master to dev July 21, 2023 12:37
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1163 (8149225) into dev (5cdf3b7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1163      +/-   ##
==========================================
- Coverage   82.18%   82.18%   -0.01%     
==========================================
  Files         154      154              
  Lines       19927    19922       -5     
  Branches     7523     7511      -12     
==========================================
- Hits        16377    16372       -5     
- Misses       3042     3043       +1     
+ Partials      508      507       -1     
Flag Coverage Δ
alpine315 68.67% <0.00%> (+0.02%) ⬆️
centos7 72.01% <50.00%> (-0.03%) ⬇️
fedora34 68.51% <0.00%> (+0.03%) ⬆️
macos-11 60.19% <33.33%> (+<0.01%) ⬆️
macos-12 0.00% <0.00%> (-60.25%) ⬇️
macos-ventura 60.17% <33.33%> (-0.01%) ⬇️
mingw32 68.94% <0.00%> (-0.02%) ⬇️
mingw64 68.94% <0.00%> (-0.04%) ⬇️
npcap 82.16% <100.00%> (-0.06%) ⬇️
ubuntu1804 72.28% <50.00%> (+<0.01%) ⬆️
ubuntu2004 69.33% <0.00%> (+0.01%) ⬆️
ubuntu2204 68.29% <0.00%> (+0.02%) ⬆️
ubuntu2204-icpx 59.24% <33.33%> (+<0.01%) ⬆️
unittest 82.18% <100.00%> (-0.01%) ⬇️
windows-2019 82.15% <100.00%> (-0.07%) ⬇️
windows-2022 82.20% <100.00%> (-0.03%) ⬇️
winpcap 82.19% <100.00%> (+0.01%) ⬆️
zstd 72.03% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Packet++/header/TLVData.h 93.16% <100.00%> (+0.11%) ⬆️

... and 20 files with indirect coverage changes

@seladb seladb merged commit 59bb2d1 into seladb:dev Aug 2, 2023
35 checks passed
fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants