Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: common event system #74

Open
sekwah41 opened this issue Aug 7, 2023 · 1 comment
Open

feat: common event system #74

sekwah41 opened this issue Aug 7, 2023 · 1 comment

Comments

@sekwah41
Copy link
Owner

sekwah41 commented Aug 7, 2023

Take a look at how both Fabric and Forge do their events and try to make one that can hook into the existing events they have, as well as take into account maintainability as well as possible performance.

Basically as long as you can make changes under the hood without changing the API side its fine.

@sekwah41
Copy link
Owner Author

sekwah41 commented Aug 7, 2023

The options its to have one central event bus or have each event have a list of its own listeners.

I think each event bus having its own list or handling it that way may be the cleanest, however having it filter them and then push them onto the individual bus could work pretty well.

Also want to take a look at ways of doing custom events so mods can talk to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant