Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve USDC flavour tickers #18

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Improve USDC flavour tickers #18

merged 3 commits into from
Aug 28, 2023

Conversation

afsardo
Copy link
Contributor

@afsardo afsardo commented Aug 24, 2023

Description

This PR proposes a change to the asset list definition, specifically for the USDC flavour tickers to improve it's clarity.

Motivation

As an Astroport contributor, we got a lot of user feedback stating that the tickers were very confusing, and in some ways it was not clear to them which pools they should LP in, I'll be honest I had an hard time initially as well for example with USDCpo and USDCso.

We internally discussed how could we improve the UX and in addition to improving our asset icons we want to make the tickers more clear, we didn't want to make this change unilaterally hence why this PR is being submitted.

@afsardo
Copy link
Contributor Author

afsardo commented Aug 24, 2023

We also are torn apart between using axl.USDC vs USDC.axl which is what Mars and Osmosis uses.

In my opinion USDC.axl would be better since it would follow the pattern we are already using for all other flavours.

Copy link
Contributor

@besated besated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Thanks for the feedback and contribution.

I agree with USDC.axl being better as well

@besated besated merged commit 31d16a9 into sei-protocol:main Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants