Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event_id into stage Pinterest events #766

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ClaudiuBasescu
Copy link

@ClaudiuBasescu ClaudiuBasescu commented Jul 12, 2023

What does this PR do?
We need to add event_id property into Pinterest Tracking Pixel events. Add event codes
It should contain messageId from Segment event.

Testing not required

@ClaudiuBasescu ClaudiuBasescu changed the title Add event_id into Pinterest events Add event_id into stage Pinterest events Jul 31, 2023
@scyzoryck
Copy link

@varadarajan-tw - can we ask you for review of those changes, please? :)

@@ -117,7 +117,8 @@ Pinterest.prototype.createPropertyMapping = function() {
order_id: 'order_id',
coupon: 'coupon',
value: 'value',
currency: 'currency'
currency: 'currency',
messageIId: 'event_id'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
messageIId: 'event_id'
messageId: 'event_id'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants