Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds segment track support in hellobar client script. #729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ayushgupta29
Copy link

What does this PR do?
This PR updates the hellobar script integration and provides the customer ability to use segment track events in hellobar event triggers.

Are there breaking changes in this PR?
No.

Testing

  • Testing completed successfully using dev environment. A popup is tied to an event named segment_event_1 which can be triggered successfully using analytics.track("segment_event_1"); which validates the use case here.

Any background context you want to provide?
We have hellobar popups being triggered on custom events. The customers who already use segment would now be able to use segment track events without integrating hellobar events directly by hooking into the segment events.

Is there parity with the server-side/android/iOS integration components (if applicable)?
NA

Does this require a new integration setting? If so, please explain how the new setting works
No.

Links to helpful docs and other external resources
https://hellobarassist.freshdesk.com/support/solutions/articles/44002393650-triggering-popups-and-bars-on-a-user-event

@ayushgupta29
Copy link
Author

Hey @pooyaj @nick-Ag - Not sure how to start the review process. Can you please help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant