Adding a plugin to Analytics causes a circular reference

[kmpa]

It seems that when an Amplitude plugin is added to Analytics using .add(plugin:) method it will cause a circular reference to Analytics.

This becomes a problem in our application as we need to be able free all services that are used in the application. Now because of the circular reference the application will crash, starting from the version 1.5.3 onwards. This version introduced a check in Analytics init method for multiple instances having the same write key.

In case no plugins are added there is no circular reference and Analytics can be freed normally.

Operating system: iOS
Reproduced: Every time

[bsneed]

Looks like an issue with the amplitude plugin not marking the analytics var as weak. Will address it over there. Thanks for finding that @kmpa!

[bsneed]

See https://github.com/segment-integrations/analytics-swift-amplitude/releases/tag/1.3.2

[sergiymomot]

@bsneed same for https://github.com/segment-integrations/analytics-swift-appsflyer

[bsneed]

Thanks @sergiymomot ! I'll go get that one updated.

[bsneed]

done!

[sergiymomot]

@bsneed thanks for the quick fix 💯